lock free driver #286
Merged
lock free driver #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhenlineo
force-pushed
the
1.1-lock-free
branch
from
ea600ad to
48fddab
Compare
lutovich
approved these changes
Dec 5, 2016
There was a problem hiding this comment.
@zhenlineo PR looks good. Could we maybe have some tests with mocks that check we close resources in #session() when driver is closed?
| // For 1. this closeResources will take no effect as everything is already closed. | ||
| // For 2. this closeResources will close the new connection pool just created to ensure no resource leak. | ||
| closeResources(); | ||
| throw new IllegalStateException( "This driver instance has already been closed" ); |
There was a problem hiding this comment.
Maybe pull creation of this exception in a method so it is not duplicated here and in assertOpen
This PR ensure that after a driver is closed, no new session could be started.
zhenlineo
force-pushed
the
1.1-lock-free
branch
from
48fddab to
b695469
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that after a driver is closed, no new session could be started.