osgify artefact MANIFEST.MF (jar + sources) #284
Conversation
* '1.1' of github.com:neo4j/neo4j-java-driver:
Fail-fast interactions with closed driver
Fix the nested tx error A session could be used to run multiple Txs, but each Tx should close before starting another tx in the same session.
Use explicit instead of auto-commit transactions in examples
Replaced `$` with `{...}` in parameter syntax for backwards compatibility
Tidied up the println in the example
Added explicit transactions to the example
Implemented `try-with-resources` in example
Added params to queries; stylistic fixes
`myserver` -> `localhost` in examples
Changed `localhost` -> `myserver:7687` in examples
|
Hi, thanks very much for the PR. Would you mind to sign CLA so that we could merge your PR? Also pls note that we might not maintain this osgi support. But you are always welcome to contribute and fix the plugin definition and |
|
Funny, I was just about the create the same PR... |
|
@zhenlineo the CLA was signed and sent to cla@... as I plan to actively use the bundle in Eclipse I will try to support it as much as possible. @dkrizic feel free to verify / comment the changes.. is the |
|
I prepared OSGi for Neo4j-OGM (see neo4j/neo4j-ogm#256). The Java Driver was the missing part. From Neo4j-OGM I reference the Java Driver as "neo4j-java-driver". You use "org.neo4j.driver". So we need to change either. |
|
@dkrizic Sorry, I didn't know your efforts regarding Neo4j-OGM. I haven't set my heart on that symbolic name ( You actually are/were referencing the fragment host as follows: <Fragment-Host>org.neo4j.ogm-api</Fragment-Host>So a But anyway, the name should follow the same pattern all over the Neo4j bundle universe. |
|
This is the list of all the Bundle-SymblicNames i use:
So I took the Maven groupId and artifactId to have a 1:1 mapping. I fully agree that all names should be consistent, so feel free to recommend something. |
|
Then I have misunderstood your comment above. I had understood that your where preferring |
|
Ok, then change it :-) |
… pattern as used in other Neo4j OSGi bundles
|
@dkrizic Done. I encourage you to create also source-bundles, so we can easily set up an Eclipse p2 repository providing runtime + sdk features. |
|
Never done that. A bundle that contains the source code? |
|
Hi @CrystalMethod! Unfortunately I can't see your CLA in the inbox. Could you please re-send it? Thanks a lot! |
|
Hello @CrystalMethod, @dkrizic. We still did not receive a signed CLA so I can't merge this PR :( |
|
Hi @dkrizic, to be able to merge these changes we will need a signed CLA from @CrystalMethod. |
|
You have my CLA now, even I did not make the Pull Request, but maybe some things in future. |
|
I've been sending the CLA yesterday. |
|
@CrystalMethod Hi I do not think we have received your CLA, but we do recevied @dkrizic's CLA. We are planing a release soon. It might be great if we could include this one into next release. |
|
Here is the part from the log file (only modified the address). So far I did not get any bounce. I will resend it with your address in CC. |
|
@CrystalMethod Thanks I got your CLA! |
when applied the generated artefacts (jar + source-jar) will contain valid OSGi manifest headers to be consumed in OSGi environments / Eclipse