Kill queries #210
Merged
Kill queries #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssion to a clean state
| /** | ||
| * Stop running more statements in this session and rest the session to a clean state. | ||
| */ | ||
| void kill(); |
There was a problem hiding this comment.
As per earlier conversation, this should be named reset and could be described as follows:
/**
* Reset the current session. This sends an immediate RESET signal to the server which both interrupts
* any statement that is currently executing and ignores any subsequently queued statements. Following
* the reset, the current transaction will have been rolled back and any outstanding failures will
* have been acknowledged.
*/
void reset();
Added test using long running procedures to test session.reset Made the client to not ack_failure while a reset is called asynclly but has not yet received success to avoid ack_failure on IDEL state in server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
session#resetto stop long running statements and reset the session to a clean state