Skip to content

Prep for clustering functionality #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 25, 2016
Merged

Conversation

technige
Copy link
Contributor

@technige technige commented Jul 25, 2016

The prep work for clustering (primarily refactoring) moved into a separate PR for clarity. This includes:

  • Relegated Config class to surface-level helper only. Separate "settings" classes have now been added to manage separation of concerns and management of defaults more sensibly. Significant new classes here are ConnectionSettings, SecurityPlan and PoolSettings.
  • Cleaned up usage of URI vs address (host:port pair). This includes more clarity around the bolt scheme to describe current behaviour as opposed to future behaviours, such as discovery. The class InternalDriver class is now called DirectDriver as we will end up with multiple Driver implementations.
  • Refactored much of the TLS code to work better with the separate SecurityPlan class. This means that some of the behaviour that was previously executed lazily (such as validating certificates) is now done eagerly and will therefore fail sooner on error.
  • Tidied up format of log messages to make consistent with other drivers.
  • Some package renaming and restructuring to better reflect the organisation of the code.

@zhenlineo zhenlineo merged commit 5ea44cb into neo4j:1.1 Jul 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants