New pool #190
Merged
New pool #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the pool is full, close the connection directly When driver is closed, session.close will close the connection directly
zhenlineo
force-pushed
the
1.0-new-pool-zhen
branch
from
8bc9779 to
fcadc2f
Compare
added 2 commits
June 17, 2016 20:05
Fixed the bug where the connection is not return to pool or closed when it is invalid Fixed the bug where the connection is disposed but being put back to pool Fixed a race condition where the connection is put back to pool after the pool is cleared Added more tests to make sure that all state changes of a pooled connection related to pooling and disposing are thread-safe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no logic for closing a connection if the connection cannot be returned to the new idle session pool (full/closed).
Failed to push to previous PR #188, so get this new one.