Fix liveness checking for unresponsive connections #1514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The driver performs liveness checking for connections when remove them from the pool. When this connections are not responsive, the driver hangs waiting for the result of the `SUCCESS` message get back. This problem occurs becaue driver are not taking in consideration the connection hint `connection.recv_timeout_seconds` in the liveness check routinge. The problem is solved by add the ConnectionReadTimeoutHandler to the pipeline also in case of liveness check ping.
injectives
reviewed
Dec 18, 2023
driver/src/main/java/org/neo4j/driver/internal/async/pool/NettyChannelHealthChecker.java
Outdated
Show resolved
Hide resolved
…yChannelHealthChecker.java Co-authored-by: Dmitriy Tverdiakov <[email protected]>
injectives
approved these changes
Dec 18, 2023
injectives
added a commit
to injectives/neo4j-java-driver
that referenced
this pull request
Dec 18, 2023
* Fix liveness checking for unresponsive connections The driver performs liveness checking for connections when remove them from the pool. When this connections are not responsive, the driver hangs waiting for the result of the `SUCCESS` message get back. This problem occurs becaue driver are not taking in consideration the connection hint `connection.recv_timeout_seconds` in the liveness check routinge. The problem is solved by add the ConnectionReadTimeoutHandler to the pipeline also in case of liveness check ping. * Remove unused imports * apply code style * Update driver/src/main/java/org/neo4j/driver/internal/async/pool/NettyChannelHealthChecker.java Co-authored-by: Dmitriy Tverdiakov <[email protected]> --------- Co-authored-by: Dmitriy Tverdiakov <[email protected]>
bigmontz
deleted the
5.x-add-connection-recv-timeout-to-liveness-check
branch
injectives
added a commit
that referenced
this pull request
Dec 18, 2023
* Fix liveness checking for unresponsive connections The driver performs liveness checking for connections when remove them from the pool. When this connections are not responsive, the driver hangs waiting for the result of the `SUCCESS` message get back. This problem occurs becaue driver are not taking in consideration the connection hint `connection.recv_timeout_seconds` in the liveness check routinge. The problem is solved by add the ConnectionReadTimeoutHandler to the pipeline also in case of liveness check ping. * Remove unused imports * apply code style * Update driver/src/main/java/org/neo4j/driver/internal/async/pool/NettyChannelHealthChecker.java --------- Co-authored-by: Antonio Barcélos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The driver performs liveness checking for connections when remove them from the pool.
When this connections are not responsive, the driver hangs waiting for the result of the
SUCCESSmessage get back.This problem occurs becaue driver are not taking in consideration the connection hint
connection.recv_timeout_secondsin the liveness check routine.The problem is solved by add the ConnectionReadTimeoutHandler to the pipeline also in case of liveness check ping.