Add support for cancellation on reactive session run #1457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
injectives
force-pushed
the
feature/sessionrun
branch
5 times, most recently
from
8e7df8d to
b32717a
Compare
injectives
changed the title
injectives
force-pushed
the
feature/sessionrun
branch
from
7f93287 to
791f79f
Compare
This update brings support for cancelling subscription on reactive session `run` methods, like: - `org.neo4j.driver.reactive.ReactiveSession.run(..)` - `org.neo4j.driver.reactivestreams.ReactiveSession.run(..)` If subscription is cancelled before an instance of the `ReactiveResult` is published, the driver will rollback the initiated query by sending the Bolt `RESET` message and will release the network connection back to its connection pool. This will be done in the background. Once the `ReactiveResult` is published, the cancellation with the rollback is no longer possible. In addition, this update makes the driver wait until subscriber subscribes to the publisher before dispatching the query to the server. Previously, the driver would do that immediately upon calling the `run` method.
injectives
force-pushed
the
feature/sessionrun
branch
from
791f79f to
34d8511
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update brings support for cancelling subscription on reactive session
runmethods, like:org.neo4j.driver.reactive.ReactiveSession.run(..)org.neo4j.driver.reactivestreams.ReactiveSession.run(..)If subscription is cancelled before an instance of the
ReactiveResultis published, the driver will rollback the initiated query by sending the BoltRESETmessage and will release the network connection back to its connection pool. This will be done in the background.Once the
ReactiveResultis published, the cancellation with the rollback is no longer possible.In addition, this update makes the driver wait until subscriber subscribes to the publisher before dispatching the query to the server. Previously, the driver would do that immediately upon calling the
runmethod.