Skip to content

Refactor #1454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 11, 2023
Merged

Refactor #1454

merged 6 commits into from
Jul 11, 2023

Conversation

injectives
Copy link
Contributor

@injectives injectives commented Jul 11, 2023

This update includes general refactoring, like:

  • converting to local variables
  • removal of empty methods
  • removal of redundant throws
  • making eligible classes static
  • removal of identical override methods
  • upgrade to enhanced switch
  • update to text block
  • using pattern variables
  • using records
  • using collection factory calls

@injectives injectives marked this pull request as draft July 11, 2023 12:28
This update includes general refactoring, like:
- converting to local variables
- removal of empty methods
- removal of redundant throws
- making eligible classes static
- removal of identical override methods
- upgrade to enhanced switch
- update to text block
- using pattern variables
- using records
- using collection factory calls
@injectives injectives force-pushed the feature/refactoring1 branch from 7c1d71f to 9264ddd Compare July 11, 2023 14:00
@injectives injectives changed the title refactor Refactor Jul 11, 2023
@injectives injectives marked this pull request as ready for review July 11, 2023 14:01
@injectives injectives requested a review from bigmontz July 11, 2023 14:48
Copy link
Contributor

@bigmontz bigmontz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The examples should not change and the switch case in the DriverFactory seems wrong

@injectives injectives requested a review from bigmontz July 11, 2023 15:34
Copy link
Contributor

@bigmontz bigmontz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@injectives injectives merged commit 88c2c22 into neo4j:5.0 Jul 11, 2023
@injectives injectives deleted the feature/refactoring1 branch July 11, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants