Improve explicit transaction terminated state handling #1445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
injectives
force-pushed
the
feature/txt-n
branch
5 times, most recently
from
e1613f7 to
89b0c0c
Compare
injectives
changed the title
injectives
force-pushed
the
feature/txt-n
branch
6 times, most recently
from
a077644 to
855fa3c
Compare
An explicit transaction is considered terminated as soon as a failure occurs. Any usage of the terminated transaction and any of its results must be stopped and the transaction must be closed explicitly. This update aims to ensure that the driver does not send further Bolt messages in regards to the terminated transaction. In addition, a new `TransactionTerminatedException` class has been introduced. It is a subclass of the previously used `ClientException`, making this exception more specific. The exception will contain a non-null `code` if it is created based on the server's response. It will not have a code if it is generated by the driver. Depending on a failure cause, the result handles may emit other exceptions respectively, matching the driver's existing behaviour.
bigmontz
approved these changes
Jul 5, 2023
driver/src/main/java/org/neo4j/driver/internal/async/NetworkConnection.java
Outdated
Show resolved
Hide resolved
driver/src/main/java/org/neo4j/driver/internal/async/NetworkConnection.java
Outdated
Show resolved
Hide resolved
driver/src/main/java/org/neo4j/driver/internal/async/NetworkConnection.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An explicit transaction is considered terminated as soon as a failure occurs. Any usage of the terminated transaction and any of its results must be stopped and the transaction must be closed explicitly.
This update aims to ensure that the driver does not send further Bolt messages in regards to the terminated transaction.
In addition, a new
TransactionTerminatedExceptionclass has been introduced. It is a subclass of the previously usedClientException, making this exception more specific. The exception will contain a non-nullcodeif it is created based on the server's response. It will not have a code if it is generated by the driver. Depending on a failure cause, the result handles may emit other exceptions respectively, matching the driver's existing behaviour.