Skip to content

Introduce bolt_agent #1424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 25, 2023
Merged

Introduce bolt_agent #1424

merged 4 commits into from
May 25, 2023

Conversation

injectives
Copy link
Contributor

@injectives injectives commented May 15, 2023

This update introduces support for the new HELLO message bolt_agent field that is mandatory in the Bolt protocol version 5.3.

The bolt_agent value is non-configurable and follows a common format among the official drivers.

Java driver bolt_agent sample:

{"product": "neo4j-java/5.7.0-bf6c5444e19cef8b6cb7aa7e0cecf80b7f8a19a9", "platform": "Linux; 5.15.49-linuxkit; aarch64", "language": "Java/17.0.6", "language_details": "Eclipse Adoptium; OpenJDK 64-Bit Server VM; 17.0.6+10"}

This update also brings support for the Bolt protocol version 5.3.

@injectives injectives force-pushed the feature/bolt-agent branch from 858f867 to eca9ac9 Compare May 17, 2023 13:54
@injectives injectives changed the title Introduce bolt_agent and update the default user_agent Introduce bolt_agent May 17, 2023
This update introduces support for the new `HELLO` message `bolt_agent` field that is mandatory in the Bolt protocol version 5.3.

The `bolt_agent` value is non-configurable and follows a common format among the official drivers.

Java driver `bolt_agent` sample:
```json
{"product": "neo4j-java/5.7.0-bf6c5444e19cef8b6cb7aa7e0cecf80b7f8a19a9", "platform": "Linux; 5.15.49-linuxkit; aarch64", "language": "Java/17.0.6", "language_details": "Eclipse Adoptium; OpenJDK 64-Bit Server VM; 17.0.6+10"}
```

This update also brings support for the Bolt protocol version 5.3.
@injectives injectives force-pushed the feature/bolt-agent branch from eca9ac9 to 6a9bff4 Compare May 17, 2023 13:57
@injectives injectives requested review from gjmwoods and bigmontz May 25, 2023 08:34
Copy link
Contributor

@bigmontz bigmontz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change in the userAgent is not supposed to happen in this change.

@injectives injectives requested a review from bigmontz May 25, 2023 11:05
Copy link
Contributor

@bigmontz bigmontz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕴🏼

@injectives injectives merged commit 8b6932c into neo4j:5.0 May 25, 2023
@injectives injectives deleted the feature/bolt-agent branch May 25, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants