Restore Session.reset as a private API #1390
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loveleif
force-pushed
the
tx-reset-2
branch
4 times, most recently
from
50bf9df to
f2fdd2e
Compare
This reverts commit 33447f5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restores
Session.reset()as a private API. Intended for use in Cypher Shell to perform query cancellation (user press ctrl+c), which has been broken since reset was removed. We considered using 4.4 driver in 5.x as a work around, but it was decided to not merge because there were some unwanted effects (see https://github.com/neo-technology/neo4j/pull/18409).Reverts 33447f5 with the following modifications:
reset()is now not available in the public API.longRunningStatement.jaris now included in the project. Note, this module is not included as part of the parent build, it can be run locally to generate a new jar file in case of breaking procedure API changes.https://trello.com/c/pV2nRf9x/359-mechanism-for-query-cancellation