Streaming cursor #125
Merged
Streaming cursor #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| (parameters == null) || (parameters.isEmpty()) ? NO_PARAMETERS : unmodifiableMap( parameters ); | ||
| final SummaryBuilder summaryBuilder = new SummaryBuilder( new Statement( statement, unmodifiableParameters ) ); | ||
|
|
||
| this.runResponseCollector = new StreamCollector() |
There was a problem hiding this comment.
this could maybe be extracted as a method
technige
force-pushed
the
1.0-streaming
branch
from
dc425c0 to
4289c65
Compare
| @Override | ||
| public void keys( String[] names ) | ||
| { | ||
| keys = new ArrayList<>( Arrays.asList( names ) ); |
technige
force-pushed
the
1.0-streaming
branch
from
caf756f to
2959d90
Compare
| @@ -77,6 +222,9 @@ public int index( String key ) | |||
|
|
|||
| public List<String> keys() | |||
| { | |||
| while (keys == null && !done) { | |||
There was a problem hiding this comment.
Only if the server responds incorrectly and in that case and Exception will be thrown, breaking out of the loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds streaming to the Java Driver. This passes control of message retrieval to the ResultCursor class and, as such, alters slightly where expections may be thrown from. In addition, each ResultCursor instance now has a recordBuffer (instead of a static list of records) which is used in the case where the cursor needs to "soak up" records from the network due to a later cursor traversing its records first.
Note that the ConnectionPoolIT test is disabled for now. From what I can tell, the occasional failures seen with this test are connected to the new startup scripts which can return before the server port is available. Fixing this should probably be a separate issue and not something to hold up this PR.