Make reactive subscription request with Long.MAX_VALUE unbounded #1003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update ensures that unbounded reactive request is translated to unbounded Bolt request.
michael-simons
approved these changes
Sep 9, 2021
There was a problem hiding this comment.
Fine as of
A Subscription MUST support an unbounded number of calls to request and MUST support a demand up to 2^63-1 (java.lang.Long.MAX_VALUE). A demand equal or greater than 2^63-1 (java.lang.Long.MAX_VALUE) MAY be considered by the Publisher as “effectively unbounded”.
injectives
added a commit
to injectives/neo4j-java-driver
that referenced
this pull request
Sep 13, 2021
…4j#1003) * Make reactive subscription request with Long.MAX_VALUE unbounded This update ensures that unbounded reactive request is translated to unbounded Bolt request. * Update ListBasedPullHandler test class to support unbounded request
injectives
added a commit
that referenced
this pull request
Sep 13, 2021
…update testkit backend (#1007) * Add holder objects for driver, session, transaction and result objects in backend (#1001) This update also removes hardcoded fetch size in reactive backend and adds support for sending additional PULL requests when there is more data to consume. * Enable tests with custom fetch size in reactive backend (#1002) Excluding negative fetch size values. * Make reactive subscription request with Long.MAX_VALUE unbounded (#1003) * Make reactive subscription request with Long.MAX_VALUE unbounded This update ensures that unbounded reactive request is translated to unbounded Bolt request. * Update ListBasedPullHandler test class to support unbounded request * Enable unexpected interruption routing Testkit tests for reactive backend (#1004)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update ensures that unbounded reactive request is translated to unbounded Bolt request.