Lots of changes #3
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not too fond of PR's doing a lot of things, but I think it's a bit hard to extract individual changes without making them depend on each other.. so bear 🐻 with me:
ListView
on the homescreen by aWrapLayout
with buttons so the content won't render outside the viewport when a add a few more items (because Appium would not be able to click those items, unless we'd add some error-prone scrolling logic).ActionBar
to the homepage so going back and forth is more pleasant to the eyes on iOS (there was a 'jump' when going back and forth because of the height difference between the master and detail pages).Switch
'schecked
property totrue
to make the screenshot look nicer.require
statements from('ui/dialogs')
to('tns-core-modules/ui/dialogs')
as prefixing the TNS modules this way is recommended.mounted
event in the 'dialogs' examples is triggered too soon (for the page transition to complete) the navigation would break after one of those routes were triggered. Adding asetTimeout
fixes it.findElementByText
didn't work on Android, so I've addedfindElementByXPath
(which doesn't work on iOS).