Skip to content

Lots of changes #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2018
Merged

Conversation

EddyVerbruggen
Copy link
Contributor

I'm not too fond of PR's doing a lot of things, but I think it's a bit hard to extract individual changes without making them depend on each other.. so bear 🐻 with me:

  • Added a README with some basic info on how to get started running this repo locally.
  • Added margins to make the screenshots look nicer (that's what I started this PR for in the first place).
  • Replaced the ListView on the homescreen by a WrapLayout with buttons so the content won't render outside the viewport when a add a few more items (because Appium would not be able to click those items, unless we'd add some error-prone scrolling logic).
  • Added an ActionBar to the homepage so going back and forth is more pleasant to the eyes on iOS (there was a 'jump' when going back and forth because of the height difference between the master and detail pages).
  • Set the Switch's checked property to true to make the screenshot look nicer.
  • Changed the 'dialogs' examples' require statements from ('ui/dialogs') to ('tns-core-modules/ui/dialogs') as prefixing the TNS modules this way is recommended.
  • Because the mounted event in the 'dialogs' examples is triggered too soon (for the page transition to complete) the navigation would break after one of those routes were triggered. Adding a setTimeout fixes it.
  • With the latest dependencies findElementByText didn't work on Android, so I've added findElementByXPath (which doesn't work on iOS).
  • While navigating back twice will close a dialog and then navigate back works on Android, it doesn't work on iOS. On iOS we need to explicitly press the cancel/ok button of the dialog.
  • Bumped a few dependencies.
  • Generate new screenshots for iOS and Android.

@rigor789
Copy link
Member

Woot! Thanks a ton!

@rigor789 rigor789 merged commit 8853d11 into nativescript-vue:master Feb 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants