$navigator.path not updated correctly if using class style Vue components

[superalex]

I have a sample where I'm using your plugin to navigate to two different components and show the path in the $navigator.path and it works perfectly:

app.js

import Vue from 'nativescript-vue';

import App from './components/App';

import Navigator from 'nativescript-vue-navigator'
import { routes } from './routes'
Vue.use(Navigator, { routes })

new Vue({
    render: h => h(App),
}).$start();

routes/index.js

import C1 from '~/components/c1'
import C2 from '~/components/c2'

export const routes = {
    '/route-1': {
        component: C1,
    },
    '/route-2': {
        component: C2,
    }
}

compontents/App.vue

<template>
    <GridLayout class="App" rows="*, auto">
        <ContentView row="0">
            <Navigator defaultRoute="/route-1" />
        </ContentView>

        <nav row="1" />
    </GridLayout>
</template>

<script>
    import nav from "./nav";
    export default {
        components: {
            nav
        },
        data() {
            return {};
        }
    };
</script>

components/c1.vue

<template>
    <Page class="page">
        <StackLayout>
            <Label text="Component 1" />
        </StackLayout>
    </Page>
</template>

<script>
    export default {};
</script>

components/c2.vue

<template>
    <Page class="page">
        <StackLayout>
            <Label text="Component 2" />
        </StackLayout>
    </Page>
</template>

<script>
    export default {};
</script>

If I use class Style Vue components with in the components:

components/c2.vue

<template>
    <Page class="page">
        <StackLayout>
            <Label text="Component 2" />
        </StackLayout>
    </Page>
</template>

<script>
    @Component
    export default class C2 extends Vue { };
</script>

Then $navigator.path isn't correctly updated and keeps the initial value.

[rigor789]

I have no idea what's causing that with class components.

Can you create a watcher and watch $navigator.path see if changes get triggered?
$navigator itself is just a Vue instance, nothing magic going on there.

[superalex]

I tried the watcher but nothing get triggered.

I added some console logs and i found that if I do:

  Vue.mixin({
    mounted() {
      console.log("Mounted", this.$options.__path)
      // attach the current path if set to the root element
      if (this.$options.__path) {
        this.$el.setAttribute('__path', this.$options.__path)
      }
    },
  })

And navigate to a "normal" component the console shows:

JS: 'Mounted' undefined
JS: 'Mounted' '/wishlist'
JS: 'Mounted' undefined

But with a class style component just:

JS: 'Mounted' undefined
JS: 'Mounted' undefined
JS: 'Mounted' undefined

It seems class style component doesn't receive properly the $options.__path

[rigor789]

Can you share the compiled source of a class component? (it should be in platforms folder somewhere in a bundle.js if I remember correctly). It's usually a long transpiled file with all your code - but the component should be there somewhere. Might give us a clue why $options.__path is not set.

[superalex]

Sure!

The compiled source for:

<script lang='ts'>
import { Component, Vue } from "vue-property-decorator";
@Component
export default class C1 extends Vue {
}
</script>

Should be:

var C1 = /** @class */ (function (_super) {
    Object(tslib__WEBPACK_IMPORTED_MODULE_0__["__extends"])(C1, _super);
    function C1() {
        return _super !== null && _super.apply(this, arguments) || this;
    }
    C1 = Object(tslib__WEBPACK_IMPORTED_MODULE_0__["__decorate"])([
        vue_property_decorator__WEBPACK_IMPORTED_MODULE_1__["Component"]
    ], C1);
    return C1;
}(vue_property_decorator__WEBPACK_IMPORTED_MODULE_1__["Vue"]));
/* harmony default export */ __webpack_exports__["default"] = (C1);

[rigor789]

Yeah, that's way different from regular js components...

If you edit the source of the navigator, specifically this line:

nativescript-vue-navigator/index.js

Line 13 in b19adc2

routes[path].component.__path = path

If you add

if(routes[path].component.options) {
  routes[path].component.options.__path = path
}

Does that make a difference?

(ref: vuejs/vue-class-component#337)

[superalex]

¡Yes!, with that change the Watch works and $navigator.path is correctly updated :)

Thank you veru much! 🕺

[rigor789]

Great! Mind opening a PR with the change?

Perhaps add a comment above the if block explaining why this is needed, something like

// this is required to attach the path to vue-class-components. see #31
if(routes[path].component.options) {
  routes[path].component.options.__path = path
}

[superalex]

Sure! Thank you very much! El jue., 26 mar. 2020 22:10, Igor Randjelovic <[email protected]> escribió:

…

Great! Mind opening a PR with the change? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#31 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAMBU4PWMRCCALRNQLXENWDRJPAEXANCNFSM4LULJPKA> .

[github-actions]

🎉 This issue has been resolved in version 1.1.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀