fix: handle webpack source maps when library is set #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case the `library` path is set in webpack.config.js file, the URLs in sourceMaps are generated in a way that is not expected for our parser - currently we expect `webpack:///<path>`, while it becomes `webpack://<library>/<path>`. To handle this, add the correct sourceMapPathOverrides in case the user had not specified it already. Add unit tests and add as devDependency `@types/sinon`. However, the project cannot be transpiled with the current TypeScript version (2.6) when this package is installed, so update TypeScript to latest version. Use proxyquire in the tests to mock the require of the webpack.config.js file.
DimitarTachev
approved these changes
Sep 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the
librarypath is set in webpack.config.js file, the URLs in sourceMaps are generated in a way that is not expected for our parser - currently we expectwebpack:///<path>, while it becomeswebpack://<library>/<path>.To handle this, add the correct sourceMapPathOverrides in case the user had not specified it already.
Add unit tests and add as devDependency
@types/sinon. However, the project cannot be transpiled with the current TypeScript version (2.6) when this package is installed, so update TypeScript to latest version.Use proxyquire in the tests to mock the require of the webpack.config.js file.
Fixes #263