Skip to content

Allow for 'tns' platform specific files #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2019

Conversation

joshcomley
Copy link
Contributor

See #252

Allowing for debugging platform specific files at the higher ".tns.[ext]" level.

@cla-bot
Copy link

cla-bot bot commented May 16, 2019

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @joshcomley.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@ghost ghost added the new PR label May 16, 2019
@cla-bot cla-bot bot removed the new PR label May 16, 2019
@joshcomley
Copy link
Contributor Author

@cla-bot check

@cla-bot cla-bot bot added the cla: yes label Jun 2, 2019
@cla-bot
Copy link

cla-bot bot commented Jun 2, 2019

The cla-bot has been summoned, and re-checked this pull request!

@joshcomley
Copy link
Contributor Author

Please can somebody review this - my plugin just updated automatically from my own version and it broke debugging in multi-environment projects.

@Fatme
Copy link
Contributor

Fatme commented Oct 2, 2019

Hey @joshcomley,

Really sorry for the late reply!

We've reviewed your code and it seems your application is with legacy code-shared structure. If this is the case, you can follow the steps described here in order to migrate to the new structure. So, no additional logic will be needed in vscode-extension.

However, the fix seems safe so I'll merge the PR.

@Fatme Fatme merged commit ee8a3a8 into nativescript-community:master Oct 2, 2019
@joshcomley
Copy link
Contributor Author

@Fatme Thanks for the update! Is there an updated sample project with the new structure somewhere I can reference? Ideally Angular etc.

@Fatme
Copy link
Contributor

Fatme commented Oct 3, 2019

@joshcomley,

Yep, we have an updated project here. Reviewing the history of the repo, you can see how it is migrated. Maybe the most interesting commits are the followings:

@joshcomley
Copy link
Contributor Author

@Fatme thank you so much, I will have a look through all that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants