Skip to content

Use chrome-debug-adapter logger #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jul 16, 2018

Conversation

ivanovit
Copy link
Contributor

@ivanovit ivanovit commented Jun 1, 2018

Chrome-debug-adapter provides logger.

For extension host process we create channelLogger.ts which output to the ns channel.

Also added extension host logger
@ivanovit ivanovit self-assigned this Jun 1, 2018
ivanovit added 6 commits June 1, 2018 15:37
The deleted tests were focused on debug protocol. Now these scenarios should be covered by the chrome-debug-adapter-core. Currently, the new tests cover only NS related code.
Current tests for paths are generated for windows paths.
ivanovit added 5 commits July 9, 2018 16:06
In the newer versions of CLI each command can print additional warning before the actual command output.
@ivanovit ivanovit merged commit 56df155 into iiivanov/remove-ipc-2 Jul 16, 2018
@ivanovit ivanovit deleted the iiivanov/reuse-logger-2 branch July 16, 2018 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants