Skip to content

Remove custom version check #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2018
Merged

Remove custom version check #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 0 additions & 84 deletions src/common/extensionVersionService.ts
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,6 @@ export function activate(context: vscode.ExtensionContext) {
Services.extensionServer().start();
Services.analyticsService().initialize();

// Check for newer extension version
Services.extensionVersionService().isLatestInstalled.then(result => {
if (!result.result) {
vscode.window.showWarningMessage(result.error);
}
});

// Check if NativeScript CLI is installed globally and if it is compatible with the extension version
let cliVersion = Services.cli().version;
if (!cliVersion.isCompatible) {
Expand Down
10 changes: 0 additions & 10 deletions src/services/extensionHostServices.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import * as vscode from 'vscode';
import {Services as BaseServices} from './services';
import {ExtensionVersionService} from '../common/extensionVersionService';
import {ExtensionServer} from '../ipc/extensionServer';
import {AnalyticsService} from '../analytics/analyticsService';
import {WorkspaceConfigService} from '../common/workspaceConfigService';
Expand All @@ -9,7 +8,6 @@ export class ExtensionHostServices extends BaseServices {
private _globalState: vscode.Memento;

private _workspaceConfigService: WorkspaceConfigService;
private _extensionVersionService: ExtensionVersionService;
private _extensionServer: ExtensionServer;
private _analyticsService: AnalyticsService;

Expand All @@ -22,14 +20,6 @@ export class ExtensionHostServices extends BaseServices {
return this._workspaceConfigService;
}

public extensionVersionService(): ExtensionVersionService {
if (!this._extensionVersionService && !this._globalState) {
throw new Error("Global state has no value.");
}
this._extensionVersionService = this._extensionVersionService || new ExtensionVersionService(this.globalState);
return this._extensionVersionService;
}

public extensionServer(): ExtensionServer {
this._extensionServer = this._extensionServer || new ExtensionServer();
return this._extensionServer;
Expand Down