When the TNS process is finished - terminate the debugger process, too. #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanbuhov
reviewed
Apr 13, 2017
There was a problem hiding this comment.
In some cases e.g. when selecting Attach on Android (tns debug android --start is executed under the hood) the CLI process exists and this is the expected behaviour - in such cases we should not fire a TerminatedEvent. Maybe we can fire the event only if the CLI process exits with a non-zero code or just put it in a if( not "Attach on Android") clause.
|
@ivanbuhov great catch! I've added your comment + condition for code > 0 to handle this case |
ivanbuhov
approved these changes
Apr 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the TNS process has been closed we're still hanging the debugger as if you can still do something.
This is easily reproducible if there is need for interactive input from the user. For example if you have two provisioning profiles and run
launch iosfrom the app it will try to find a provisioning profile for you, get confused, can't get a decision and return an error for you to pass theteamIdas an arg. After that the TNS exits. Currently we hang, now we raise the terminate event.Another way to test: