Skip to content

Commit e4b89dc

Browse files
authored
Merge pull request #156 from EddyVerbruggen/es6-upgrade
es6 & TS 2.6 upgrade
2 parents 78869de + b253889 commit e4b89dc

File tree

7 files changed

+24
-31
lines changed

7 files changed

+24
-31
lines changed

package.json

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
"publisher": "Telerik",
1717
"bugs": "https://github.com/NativeScript/nativescript-vscode-extension/issues",
1818
"engines": {
19-
"vscode": "^1.7.0"
19+
"vscode": "^1.19.0"
2020
},
2121
"homepage": "https://www.nativescript.org/",
2222
"categories": [
@@ -25,26 +25,24 @@
2525
],
2626
"license": "SEE LICENSE IN LICENSE.txt",
2727
"dependencies": {
28-
"vscode-chrome-debug-core": "3.9.1",
28+
"vscode-chrome-debug-core": "~3.9.0",
2929
"node-ipc": "8.10.3",
30-
"source-map": "0.5.6",
30+
"source-map": "0.6.1",
3131
"xmlhttprequest": "https://github.com/telerik/node-XMLHttpRequest/tarball/master",
3232
"universal-analytics": "0.4.13",
33-
"vscode-debugadapter": "1.19.0",
34-
"vscode-debugprotocol": "1.19.0"
33+
"vscode-debugadapter": "1.26.0",
34+
"vscode-debugprotocol": "1.26.0"
3535
},
3636
"devDependencies": {
37-
"@types/es6-collections": "0.5.30",
38-
"@types/es6-promise": "0.0.32",
3937
"@types/mocha": "2.2.41",
4038
"@types/node": "6.0.46",
4139
"@types/source-map": "~0.1.0",
4240
"chrome-remote-debug-protocol": "git://github.com/roblourens/chrome-remote-debug-protocol.git",
4341
"mocha": "2.5.3",
44-
"typescript": "~2.4.0",
45-
"vsce": "1.22.0",
46-
"vscode": "1.1.0",
47-
"vscode-debugadapter-testsupport": "1.19.0"
42+
"typescript": "2.6.2",
43+
"vsce": "~1.36.0",
44+
"vscode": "~1.1.10",
45+
"vscode-debugadapter-testsupport": "1.26.0"
4846
},
4947
"scripts": {
5048
"clean": "git clean -fdx",

src/custom-typings/es6-impl/es6-impl.d.ts

Lines changed: 0 additions & 8 deletions
This file was deleted.

src/debug-adapter/adapter/adapterProxy.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,15 +40,15 @@ export class AdapterProxy {
4040
.filter(transformer => request.command in transformer)
4141
.reduce(
4242
(p, transformer) => p.then(() => transformer[request.command](request.arguments, request.seq)),
43-
Promise.resolve<void>());
43+
Promise.resolve());
4444
}
4545

4646
/**
4747
* Pass the response body back through the transformers in reverse order. They modify the body in place.
4848
*/
4949
private transformResponse(request: DebugProtocol.Request, body: any): Promise<void> {
5050
if (!body) {
51-
return Promise.resolve<void>();
51+
return Promise.resolve();
5252
}
5353

5454
const bodyTransformMethodName = request.command + 'Response';
@@ -58,7 +58,7 @@ export class AdapterProxy {
5858
.filter(transformer => bodyTransformMethodName in transformer)
5959
.reduce(
6060
(p, transformer) => p.then(() => transformer[bodyTransformMethodName](body, request.seq)),
61-
Promise.resolve<void>());
61+
Promise.resolve());
6262
}
6363

6464
/**

src/debug-adapter/connection/iosConnection.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ export class IosConnection implements INSDebugConnection {
171171
}
172172

173173
public enable() : Promise<void> {
174-
return Promise.resolve<void>();
174+
return Promise.resolve();
175175
}
176176

177177
public close(): void {

src/debug-adapter/webKitDebugAdapter.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ export class WebKitDebugAdapter implements DebugProtocol.IDebugAdapter {
6363
private clearTargetContext(): void {
6464
this._scriptsById = new Map<WebKitProtocol.Debugger.ScriptId, WebKitProtocol.Debugger.Script>();
6565
this._committedBreakpointsByUrl = new Map<string, WebKitProtocol.Debugger.BreakpointId[]>();
66-
this._setBreakpointsRequestQ = Promise.resolve<void>();
66+
this._setBreakpointsRequestQ = Promise.resolve();
6767
this._lastOutputEvent = null;
6868
this.fireEvent({ seq: 0, type: 'event', event: 'clearTargetContext'});
6969
}
@@ -368,7 +368,7 @@ export class WebKitDebugAdapter implements DebugProtocol.IDebugAdapter {
368368
this._webKitConnection = null;
369369
}
370370

371-
return Promise.resolve<void>();
371+
return Promise.resolve();
372372
}
373373

374374
public setBreakpoints(args: DebugProtocol.ISetBreakpointsArgs): Promise<DebugProtocol.ISetBreakpointsResponseBody> {
@@ -403,7 +403,7 @@ export class WebKitDebugAdapter implements DebugProtocol.IDebugAdapter {
403403

404404
private _clearAllBreakpoints(url: string): Promise<void> {
405405
if (!this._committedBreakpointsByUrl.has(url)) {
406-
return Promise.resolve<void>();
406+
return Promise.resolve();
407407
}
408408

409409
// Remove breakpoints one at a time. Seems like it would be ok to send the removes all at once,
@@ -412,7 +412,7 @@ export class WebKitDebugAdapter implements DebugProtocol.IDebugAdapter {
412412
// does not break there.
413413
return this._committedBreakpointsByUrl.get(url).reduce((p, bpId) => {
414414
return p.then(() => this._webKitConnection.debugger_removeBreakpoint(bpId)).then(() => { });
415-
}, Promise.resolve<void>()).then(() => {
415+
}, Promise.resolve()).then(() => {
416416
this._committedBreakpointsByUrl.set(url, null);
417417
});
418418
}
@@ -621,7 +621,7 @@ export class WebKitDebugAdapter implements DebugProtocol.IDebugAdapter {
621621
return { variables };
622622
});
623623
} else {
624-
return Promise.resolve();
624+
return Promise.resolve(null);
625625
}
626626
}
627627

src/tests/nsDebugClient.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ export class NsDebugClient extends DebugClient {
4242
this.onNextTime(event).then(e => this.onNthTime(--n, event));
4343
}
4444

45-
public assertSetBreakpoints(path: string, breakpoints: { line: number, condition?: string }[]): Promise<{}> {
45+
public assertSetBreakpoints(path: string, breakpoints: { line: number, condition?: string }[]): Promise<void> {
4646
return this.setBreakpointsRequest({
4747
lines: breakpoints.map(b => b.line),
4848
breakpoints: breakpoints,

src/tsconfig.json

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"compilerOptions": {
3-
"target": "es5",
3+
"target": "es6",
44
"module": "commonjs",
55
"moduleResolution": "node",
66
"sourceMap": true,
@@ -10,9 +10,12 @@
1010
"outDir": "../out",
1111
"allowJs": true
1212
},
13+
"exclude": [
14+
"node_modules",
15+
"tests"
16+
],
1317
"files": [
1418
// typescript definitions
15-
"custom-typings/es6-impl/es6-impl.d.ts",
1619
"custom-typings/universal-analytics/ua.d.ts",
1720
"custom-typings/debugProtocolExtensions.d.ts",
1821
"custom-typings/webKitProtocol.d.ts",

0 commit comments

Comments
 (0)