Skip to content

Fix/remove typing ext for py38 for repo #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

nadobando
Copy link
Owner

Issue aws-powertools#280

Description of changes:

  1. Added if block to know if typing_extensions should be imported based on the python version.
    if python >= 3.8 typing extensions will not be imported and the native implementation will be used
    else will try to import typing_extensions and catch the ImportError

  2. Updated modules which imported this dependency.

  1. Updated pyproject.toml to only install typing-extensions when python version is <3.8
    Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@nadobando nadobando closed this Feb 3, 2021
@nadobando nadobando deleted the fix/remove-typing-ext-for-py38-for-repo branch February 3, 2021 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant