Allowing both Charset & Collation #808
Conversation
|
Thanks :) I'll look at this later today. |
|
One change I'm going to propose from our conversation is that you either:
or
You can update your master branch with whichever, or I'll just cherry pick your PR with option 1 automatically :) |
|
Updated with 2, I think it's a little cleaner to have config options that correspond to their values. |
| @@ -17,22 +17,22 @@ test('ConnectionConfig#Constructor', { | |||
| }, | |||
|
|
|||
| 'allows additional options via url query': function() { | |||
| var url = 'mysql://myhost/mydb?debug=true&charset=BIG5_CHINESE_CI'; | |||
| var url = 'mysql://myhost/mydb?debug=true&collation=BIG5_CHINESE_CI'; | |||
There was a problem hiding this comment.
Undo this test change; even though it'll say the old "charset"; it needs to work and we don't want to alter existing tests if not necessary (this of this test testing that you can still get charset a collation).
|
Updated, let me know if there's anything else you spot here. |
|
Thanks for the ping :) I saw the update earlier and was glad to see the test passed. I'll get to it as soon as I can. |
* auth: add sha256_password implementation * auth: fix sha256_password implementation * auth: add sha256_password tests * auth: remove test pub key by ascii encoded version * packets: allow auth responses longer than 255 bytes * utils: correct naming of registries * auth: allow using a local server pub key
@dougwilson here's the change that allows specifying both charset & collation in the config, per our discussion. Feel free to change it if you'd prefer there only be one option
charsetfor now rather than bothcharsetandcollationso as not to confuse things.