Do not console.warn non-sense Error #744
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, emitting a "warn" event with pool is much more useful.
|
Is there anyone can review this? Or giving out other solutions to get rid of these meaningless console.warn is acceptable. |
|
Sorry, I've been avoiding this because I've never used I'll have to look into the |
|
@dougwilson Any solutions to get rid of |
|
No one says the original design was good :) |
dougwilson
added a commit
that referenced
this pull request
Apr 22, 2014
dveeden
pushed a commit
to dveeden/mysql
that referenced
this pull request
Jan 31, 2023
* Fix error message for unsupported isolation level. It was "mysql: unsupported isolation level: \a" due to wrong conversion from int to string. See also golang/go#23632 * Add myself and sort authors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
console.warnin lib/PoolCluster.js is useless, for it does not tell me which node is suffering error and the details of the node.Instead, we should emit a "warn" event with pool, which is much more useful. Anyone who concerns about these messages can handle it themselves.