Add trace flag for configuring long stack traces #713
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new connection option
trace
to control if long stack traces are generated. The default if not specified is to generate them, which keeps the default behavior the same.This also makes a minor tweak on how the initial stack is generated. Before it was generated in the
Sequence
constructor, so it captured the stack at the time the protocol sequence was generated. The stack is now captured inProtocol.prototype._enqueue
. In all cases within the public API this captures the same stack, except there will be the extra call to_enqueue
at the top of the stack. The following case, though, will be positively altered:The change of the call site capture essentially moves the stack when using
require('mysql').createQuery
from the call tocreateQuery
to the actual location where the query was handed over to the connection.closes #710