query.stream()._read without connection is a no-op #689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Can you provide a unit test for this that shows the problem? |
|
I rebased on top of commit that adds the test, if you checkout 5b06d1b you can see it failing. |
Fixes errors when `.stream()` is called on a query without a connection (e.g. a query created using `createQuery`).
|
I've just rebased this off of master so that tests should stop failing due to not having |
|
👍 - looks good |
felixge
added a commit
that referenced
this pull request
Jan 16, 2014
query.stream()._read without connection is a no-op
|
💖 thx |
|
No thank you! 🍺 On 15 January, 2014 at 11:20:27 PM, Felix Geisendörfer ([email protected]) wrote: thx — |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes errors when
.stream()is called on a query without aconnection (e.g. a query created using
createQuery).