always pass handshakeInitializationPacket to ChangeUser

[seanmonstar]

If the queue is empty before calling a ChangeUser sequence, the sequence will be started without being passed the handshake packet. This makes sure it gets passed.

Additionally, validateEnqueue now has a test that handeshake() was called before changeUser().

fixes #374

[sidorares]

LGTM
Can we have a test for this? I guess it would be connect + ChangeUser after some timeout (say, 2s) to make sure queue is empty

[seanmonstar]

added said test.

[sidorares]

It's actually possible to run it on travis - see https://github.com/sidorares/nodejs-mysql-native/blob/master/.travis.yml

[seanmonstar]

i just copied what was in test-change-user.js.

[seanmonstar]

poke

[dougwilson]

I believe you really need to alter your test (even though you coped it from another test) so that it runs on Travis CI first.

[seanmonstar]

Ok, fixed up the tests so they can run on Travis.

Noticed that changeUser({ user: 'does-not-exist' }) did not cause an error on my branch, or on master. I made it try to change the database instead, and it errored that way.

[sidorares]

👍

[felixge]

@seanmonstar LGTM for most parts - thanks! I gave you git/npm push access, feel free to merge release when you're happy with it.

My only nitpick: It seems like there is some code duplication now, as the logic for handling Sequences.ChangeUser exists in two places after this patch.

[seanmonstar]

@felixge good point. i included another commit to consolidate that code into a single method. r?

[felixge]

LGTM, feel free to merge when you're ready.