Fixed timezone test not to be dependent on the millisecond executed. #600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixge
added a commit
that referenced
this pull request
Oct 1, 2013
Fixed timezone test not to be dependent on the millisecond executed.
|
@nanek fantastic, thx you so much for the patch. |
dveeden
pushed a commit
to dveeden/mysql
that referenced
this pull request
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timezone test would fail if the current millisecond value was 500 or over as MySQL would round up to the next second and then the assertion checking the time at a second precision would fail. As noted in the comment,
datetimein MySQL does not store millisecond values, unlessdatetime(6)is used and MySQL version is greater than 5.6.4.Also added node 0.10 to travis-ci.