Skip to content

Add the milliseconds part when converting Date objects. #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 15, 2013
Merged

Add the milliseconds part when converting Date objects. #538

merged 3 commits into from
Jul 15, 2013

Conversation

chaoran
Copy link
Contributor

@chaoran chaoran commented Jul 11, 2013

fixes #536

@felixge
Copy link
Collaborator

felixge commented Jul 12, 2013

@chaoran thx! Could you have a look at why the travis build is failing?

@chaoran
Copy link
Contributor Author

chaoran commented Jul 12, 2013

@felixge Sorry It's breaking the tests. I will fix the tests with another commit.

@dresende
Copy link
Collaborator

LGTM 👍

felixge added a commit that referenced this pull request Jul 15, 2013
Add the milliseconds part when converting Date objects.
@felixge felixge merged commit e06f9e8 into mysqljs:master Jul 15, 2013
@felixge
Copy link
Collaborator

felixge commented Jul 15, 2013

💖 thx @chaoran

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

DATETIME type conversion problem
3 participants