Update Readme.md #529
Merged
Update Readme.md #529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix minor bugs in code samples
|
Thanks for the patch! I'll take the semicolons but I'd like to keep the commas : ). Can u adjust the PR? About the commas: They are legal in JS, and help the editing process (you can remove or add any line individually without special rules for the last line in a list). |
Fix minor bugs in code samples (returned some commas and even added new ones)
|
You are absolutely right about trailing commas. I blame my client-side-JavaScript experience, that's what forced me to remove them. :) I've returned the commas (and even added new ones). |
|
@clbn 💖 thx for the help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix minor bugs in code samples