Skip to content

Fix : field.length undefined #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2013
Merged

Fix : field.length undefined #520

merged 1 commit into from
Jun 20, 2013

Conversation

ifsnow
Copy link
Contributor

@ifsnow ifsnow commented Jun 20, 2013

fixes #519 (field.length undefined in typeCast function)

dresende added a commit that referenced this pull request Jun 20, 2013
@dresende
Merge pull request #520 from ifsnow/fix-field-length
0e3988c 
Fix : field.length undefined
@dresende dresende merged commit 0e3988c into mysqljs:master Jun 20, 2013
@felixge
Copy link
Collaborator

felixge commented Jun 22, 2013

Is this a fix or just renaming a property? If it's the later, this might break other people's code : /

@ifsnow
Copy link
Contributor Author

ifsnow commented Jun 22, 2013

It's a fix. FieldPacket constructor defined length property.

@felixge
Copy link
Collaborator

felixge commented Jun 25, 2013

@ifsnow thanks for clarifying! 💖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

field.length undefined in typeCast function
5 participants
@ifsnow @felixge @rwky @apparatusdeus @dresende