Don't delete query values after formatting #509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They may be useful to other users of the query object
|
The reason for doing it originally was that I didn't want to expose a new property on query objects, but now I think it makes more sense to leave it in place instead of deleting it part-way through the objects lifetime. |
|
LGTM |
|
Thank you for pointing it out. |
dresende
added a commit
that referenced
this pull request
Jun 17, 2013
Don't delete query values after formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back when I submitted #358, I added a line to delete
query.valuesafter the query had been formatted. This pull request removes that line because it's very handy to be able to log them in a structured manner in parts of the code that wouldn't normally have access to the parameters.