Add Pool options : maxWait, initialSize, minIdle, maxIdle
#505
Conversation
|
@ifsnow I don't have time to review, but I'd say go ahead and merge this unless anybody has any objections ; ). |
|
We got probably rid of most of the objections in #499. I will try to review this in next week. |
|
@tellnes awesome, thank you so much! |
|
Sorry for not reviewing this yet. Will see if I can find some time in next week. |
|
Whats the status on this? Pool connection options are severely lacking in node-mysql and this pull request seems to add the needed functions... |
|
@joekarl - I'll try to add this to v2.1 |
|
@ifsnow could you rebase and check tests please? |
dougwilson
force-pushed
the
master
branch
3 times, most recently
from
17209da to
76de66e
Compare
|
What's the status on this one? This seems like a feature that should have been implemented long ago. |
|
@frxstrem it was left off waiting for the author to check the tests and rebase. You're welcome to take over this pull request and own getting it working on the latest version of this module if you are interested. |
dougwilson
force-pushed
the
master
branch
4 times, most recently
from
5847ec8 to
be37e88
Compare
dougwilson
force-pushed
the
master
branch
3 times, most recently
from
65c4c0c to
fa96a75
Compare
|
I'm here to work on this again. Sorry I took too long. |
|
I'm sorry to keep you waiting too long. I posted a new PR( #1591) about this. |
|
Closing in favor of the new PR with updated code :) |
I did the work improving the function of the
Pool.I will be good if these options(
maxWait,initialSize,minIdle,maxIdle, ..) were helpful.This is the just beginning. I will improve continuously.