Fix issue #473 (Make Pool emit a "connection" event) #474
Conversation
…ccesfully been added to the pool, but before any Pool#getConnection callbacks are called. This allows for a pool of connections to e.g. set MySQL session variables on each of its connections before they are used
…ion if the queue of pending connection requests gets larger than the queueLimit. This is a safeguard to detect code which leaks connections sooner rather than later. The new functionality covered in test/integration/pool/test-queue-limit.js
|
The test case which fails is really suposed to fail or are you pushing some fix? |
|
Thanks for swift response @dresende. I added the failing test case to demonstrate an issue with the The answer may be to simply leave things as is, but I do think expectations may be violated by letting the user create a connection themselves but not letting them issue any queries on it until after it has been added to the pool. If 874f51c is good to merge but we don't want to do anything about the |
|
This issue is being addressed in #486. |
The first of these two patches adds a failing test case which demonstrates an issue with the current implementation of
Pooland itscreateConnectionoption.The second patch makes
PoolanEventEmitterwhich emits the"connection"event when it successfully adds an open connection to the pool. This second patch also includes a test case demonstrating the use of and need for something like this (in order to set session variables on pooled connections before they are used).Cheers!
Marcus