-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Added Amazon RDS ca-central-1 CA #1809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added Amazon RDS ca-central-1 CA
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the new cert! Looks like the CI is failing because you may have accidentally overlooked the last step in https://github.com/mysqljs/mysql#contributing
I'll get your PR fixed up, but wanted to let you know in case you are able to get it fixed up before myself.
Interestingly, I couldn't see the issue on the Windows computer I used
yesterday to make the change.
I just ran it on my MacBook and I can see the same error than on the CI.
I'll correct this and push.
|
Hi @CyranoB I'm not sure how the fingerprint was calculated in your PR, but I re-calculated it to properly match the given certificate. |
Hi Douglas,
Any idea when the next release will be released? I supposed this pull
request will be included in v2.14.1.
Best regards,
Eddie
|
Hi @CyranoB this PR was landed after a semver-minor landed in |
Hi @dougwilson Sorry to bother you again, but do you know when 2.15.0 will be released? |
I was waiting to hear back on #1811 (comment) |
This adds Amazon RDS ca-central-1 CA to the embedded SSL profiles.