Skip to content

A bug fix for the Types.LONGLONG number range #1376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 16 commits into from
Closed

A bug fix for the Types.LONGLONG number range #1376

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
9b7d355
A bug fix for the Types.LONGLONG number range
Dinwy Mar 29, 2016
c012136
Update RowDataPacket.js
Dinwy Mar 29, 2016
8d68cdb
A bug fix for the Types.LONGLONG number range
Dinwy Mar 29, 2016
2b160b9
A bug fix for the Types.LONGLONG number range
Dinwy Mar 29, 2016
21d8bad
add tests
Dinwy Mar 29, 2016
0345aeb
Merge branch 'master' of https://github.com/Dinwy/node-mysql
Dinwy Mar 29, 2016
b55d927
Delete test0.js
Dinwy Mar 29, 2016
b8ece31
Fix bigint out of range problem
Dinwy Mar 29, 2016
7588c28
Fix bigint out of range problem
Dinwy Mar 30, 2016
fc77df8
Fixed bigint out of range problem
Dinwy Mar 30, 2016
3032796
Fixed bigint out of range problem
Dinwy Mar 30, 2016
bd1ce80
Merge pull request #1 from Dinwy/iss1371
Dinwy Mar 30, 2016
4273828
Fix #1371 bigint error
Dinwy Apr 6, 2016
d31b186
Merge pull request #2 from Dinwy/iss1371
Dinwy Apr 6, 2016
fb1d14d
Fix #1371 bigint error
Dinwy Apr 6, 2016
ff37d5d
Merge pull request #3 from Dinwy/iss1371
Dinwy Apr 6, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/protocol/packets/RowDataPacket.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ function typeCast(field, parser, timeZone, supportBigNumbers, bigNumberStrings,
numberString = parser.parseLengthCodedString();
return (numberString === null || (field.zeroFill && numberString[0] == "0"))
? numberString
: ((supportBigNumbers && (bigNumberStrings || (Number(numberString) > IEEE_754_BINARY_64_PRECISION)))
: ((supportBigNumbers && (bigNumberStrings || (Number(numberString) >= IEEE_754_BINARY_64_PRECISION) || (Number(numberString) <= -IEEE_754_BINARY_64_PRECISION)))
? numberString
: Number(numberString));
case Types.BIT:
Expand Down
2 changes: 1 addition & 1 deletion test/common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ function mergeTestConfig(config) {
port : process.env.MYSQL_PORT,
user : process.env.MYSQL_USER,
password : process.env.MYSQL_PASSWORD
}, config);
}, config);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needless whitespace change. This file should probably remain untouched in this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How could I miss this. Thanks.


return config;
}
Expand Down
37 changes: 37 additions & 0 deletions test/integration/connection/test-query-bigint.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
var assert = require('assert');
var common = require('../../common');

var table = 'bigint_test';

common.getTestConnection({supportBigNumbers: true}, function (err, connection) {
assert.ifError(err);

common.useTestDb(connection);

connection.query([
'CREATE TEMPORARY TABLE ?? (',
'`id` int(11) unsigned NOT NULL AUTO_INCREMENT,',
'`big` bigint,',
'PRIMARY KEY (`id`)',
') ENGINE=InnoDB DEFAULT CHARSET=utf8'
].join('\n'), [table], assert.ifError);

connection.query('INSERT INTO ?? SET ?', [table, {big: '9223372036854775807'}]);
connection.query('INSERT INTO ?? SET ?', [table, {big: '-9223372036854775807'}]);
connection.query('INSERT INTO ?? SET ?', [table, {big: '1111111111111111111'}]);
connection.query('INSERT INTO ?? SET ?', [table, {big: '-1111111111111111111'}]);
connection.query('INSERT INTO ?? SET ?', [table, {big: '9007199254740993'}]);
connection.query('INSERT INTO ?? SET ?', [table, {big: '-9007199254740993'}]);

connection.query('SELECT * FROM ??', [table], function (err, rows) {
assert.ifError(err);
assert.equal(rows.length, 6);
assert.strictEqual(rows[0].big, '9223372036854775807');
assert.strictEqual(rows[1].big, '-9223372036854775807');
assert.strictEqual(rows[2].big, '1111111111111111111');
assert.strictEqual(rows[3].big, '-1111111111111111111');
assert.strictEqual(rows[4].big, '9007199254740993');
assert.strictEqual(rows[5].big, '-9007199254740993');
connection.end(assert.ifError);
});
});