allow browserify

[chpio]

Hi,

you can bundle node packages with browserify. Unfortunately it only works with static requires. So i changed all require-all with static requires.

[sidorares]

@t128 what is the point of browserifying node-mysql?

[chpio]

bundle it into one js file eg: browserify/browserify#1277 (comment)

this has a few advantages:

• the app starts a lot faster (node needs to load only one file)
• the app is a lot smaller (in my examle app ~50mb to ~1mb)
• you can transfer it more easily to eg the server

[sidorares]

ok, it might make sense with node-webkit, but why bundle there when you can use native require?

[sidorares]

also see related #961

[sidorares]

sorry, have not read your comment until the end. ~50mb to ~1mb seems like a lot, but I guess it's not because of one file but because you exclude unused files. This can be done via coverage-like instrumentation to mark files for exclusion before packaging

[chpio]

yeah, sorry, i changed the comment.

so, it will never happen, as only node.js is really supported?

ps: uglify halved the size to 400kb :)

[sidorares]

I'm not completely against your PR, but forcing only static require is actually bad for performance: I often require conditionally features that not always used to make startup time better

[dougwilson]

We would only even accept this PR if this library was usable in a browser, but as far as I know, you cannot use it in a browser because you cannot make raw sockets there.

Could you perhaps show/tell us how you are using this module in a web browser?

[sidorares]

@dougwilson it's used in node-webkit and bundled for performance considerations, not because of lack of module system

[dougwilson]

Why are you requiring itself? You can remove this.

[dougwilson]

Oh, gotcha. I left a couple line notes of two things that need to be fixed.

[chpio]

hmm, you'r right. i missed the [A-Z]

[dougwilson]

We can probably remove require-all from the list of dependencies now, no?

[chpio]

no, not really: https://github.com/felixge/node-mysql/blob/de5913227dbbaacbbdf22ee38689d090e1451be9/test/run-cov.js#L29

[sidorares]

move it to devDependencies ?

[chpio]

dat error:

AssertionError: 'Fri Jun 26 2015 09:50:00 GMT+0000 (Coordinated Universal Time)' === 'Fri Jun 26 2015 09:49:00 GMT+0000 (Coordinated Universal Time)'

:(

[dougwilson]

@t128 don't worry about that error :) We had a volunteer who would look into it at #1045 but still no resolution.