Performing queries docs #1050
Closed
Performing queries docs #1050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
April 7, 2015 10:56
There are more instances of `function()` than `function ()`. This commit makes them consistently the former.
Less to read is generally easier to understand.
The options object field is named 'values', referring to it as 'parameters' when passed as an argument might lead to confusion.
The majority of code examples use `err` instead of `error`. This commit makes it consistent across the readme.
This is likely a less used form but still works. I'm unsure of the code formatting but it does make the values array stand out from the options object.
|
Thank you, @adrianblynch ! You'll notice I didn't include all the various commits here, mainly because I didn't really want to hold up the PR with them all, so I just took what reflected the PR title. Please feel free to open any additional PRs you feel are appropriate! |
seangarner
pushed a commit
to seangarner/node-mysql
that referenced
this pull request
May 11, 2015
dveeden
pushed a commit
to dveeden/mysql
that referenced
this pull request
Jan 31, 2023
Implements a Travis CI task that checks if the driver compiles on all platforms supported by Go. Fixes mysqljs#1050
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.