typeCast doesn't seem to work when using a connection pool

[EnzoMartin]

I'm using a connection pool, and in the pool config I pass the typeCast option (using the function in the readme as I'm needing to cast tinyint(1) to booleans). I notice that if I output a connection's typeCast function, the setting is correctly configured there, but when I add an output to the first argument it gets back, instead of a field, it gets the table information.

This makes me unable to use typeCast as a global configuration option for all queries, as I need to set it on every query that I want to convert tinyint to booleans

[dougwilson]

Adding typeCast to the pool definitely works. Can you post the table DDL you are querying, the pool configuration code you are using, and what the "output to the first argument it gets back" is?

[dougwilson]

Actually, it looks like it may indeed not work.

[dougwilson]

Specifically, it's only a bug with pool.query; if you acquire a connection from the pool and do conn.query on that, it'll have the pool's type cast setting.

[EnzoMartin]

Sorry, I should have specified it's when using pool.query. As a side note, doing pool.query and specifying the typeCast then works fine

[EnzoMartin]

Fastest fix ever, awesome, thank you 👍

[dougwilson]

Yep. I actually just fixed it :) You can verify it by doing npm install felixge/node-mysql; I should release a patch version today.