-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Cannot connect using node 0.10.5 #746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi! It looks like you may have pasted the wrong commit. Are you referring to commit fe4c2f5 ? |
Indeed, dunno how copypaste bit me, but bit me it did |
That's OK, I just wanted to make sure we started looking in the right place :) |
OK, it looks like you may need to use node.js 0.10.7 or higher for 0.10.x releases; I'll see about getting support added back for node.js >= 0.10.0 < 0.10.7 |
Running authentication on node.js 0.10.1 results in the following error:
|
This switches node.js 0.10 back to the old sha1 function due to some bugs in early node.js 0.10 versions. node.js >= 0.10.0 < 0.10.5 throw an error from `hash.setEncoding` node.js 0.10.5 does not honor `hash.setEncoding` for `hash.write` and the string is interpreted as utf8 and corrupted. fixes #746 fixes #752
It seems commit 0c44758 broke authentication ni node 0.10.5, whose sha1 digest function still doesn't return a Buffer.
Reverting to pre - 0c44758 fixes that issue
See:
The text was updated successfully, but these errors were encountered: