Calling connection.release() outputs to console

[nibblesnbits]

After starting to use connection pooling in my server I noticed that every time I close a connection using .release() I get the following message in my output:

Calling conn.end() to release a pooled connection is deprecated. In next version calling conn.end() will be restored to default conn.end() behavior. Use conn.re lease() instead.

This is filling up my output logs. I should be able to silence this sort of thing.

[felixge]

Have you tried using conn.release() instead?

[felixge]

Ah wait, you're saying you're using release() already? If that's the case something is broken, needs a patch.

[nibblesnbits]

Yes, I'm using conn.release() like this:

`var pool = mysql.createPool({
host: config.server,
user: config.user,
password: config.password,
database: config.db
});
pool.getConnection(function(err, connection) {
// do my stuff
connection.release();
});

[dougwilson]

What version of this module are you using? The current version v2.0.0 definitely does not print that if you call connection.release() only if you call connection.end() on a pooled connection, so perhaps you have a .end() call somewhere you are not seeing? The following will point to the call. If you are making a .release() call at that point, please paste the generated stack trace:

(function (pc) {
  var end = pc.end;
  pc.end = function () { console.warn(new Error().stack); return end.apply(this, arguments); };
}(require('mysql/lib/PoolConnection'));

[dougwilson]

Another way to get the trace is at the beginning of your server, do something like console.warn = console.trace which will change warns into traces, as the message you are seeing uses warn.

[nibblesnbits]

I'm using version 2.0.0-rc1. Was it present in that version?

[dougwilson]

Nope. Please try one of the options above to trace it back. If it actually traces back to a .release() call in your code, please paste the trace here so we can see what within this library is calling the deprecated .end().

[nibblesnbits]

(embarassed)

We can close this issue. I found a hidden call to .end() deep in my code. Sorry for the worry.

[dougwilson]

No problem. It can be hard to find it easily. Glad the trace helped you pinpoint it.

[sidorares]

@dougwilson - there is console.trace() which does the same as console.warn(new Error().stack) - https://github.com/joyent/node/blob/master/lib/console.js#L88

[dougwilson]

Thanks, @sidorares, but my comment after that was to do console.warn = console.trace.

[sidorares]

oops, my bad, sorry - missed that next comment