Callbacks with async?

[DaAwesomeP]

I am trying to run a query in an eachSeries. The problem is that doneCallback gets called before the query's callback is complete. How can I fix this?

var dataset = new Array("1","2");
var allVar1 = new Array();
async.eachSeries(dataset, function (set, doneCallback) {
    var selectallquery = 'SELECT * FROM `data' + set + '` ORDER BY id DESC LIMIT 1';
    mysqlcon.query(selectallquery, function(err, rows, fields) {
        if (err) throw err;

        allVar1.push(rows[0].var1);    // This ends up happening after or during the "Do Afterwards."

    });
    return doneCallback(null);  // Fires prematurely
}, 
function(err) {
    // Do afterwards
    console.log(allVar1);
});

Thanks!

[dougwilson]

Just like any code that uses callbacks, your doneCallback neds to be within the callbck from the query method:

var dataset = new Array("1","2");
var allVar1 = new Array();
async.eachSeries(dataset, function (set, doneCallback) {
    var selectallquery = 'SELECT * FROM `data' + set + '` ORDER BY id DESC LIMIT 1';
    mysqlcon.query(selectallquery, function(err, rows, fields) {
        //if (err) throw err; // <-- Do not throw errors in callbacks
        if (err) return doneCallback(err); // <-- This is what the first argument to doneCallback is for

        allVar1.push(rows[0].var1);    // This ends up happening after or during the "Do Afterwards."

        doneCallback(null); // <-- Place here
    });
    //return doneCallback(null);  // <-- No, not here
}, 
function(err) {
    // Do afterwards
    console.log(allVar1);
});

[DaAwesomeP]

Thanks! My bad.