Skip to content

Pool#_removeConnection seems rather inefficient #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ronkorving opened this issue Oct 10, 2013 · 0 comments
Closed

Pool#_removeConnection seems rather inefficient #611

ronkorving opened this issue Oct 10, 2013 · 0 comments

Comments

@ronkorving
Copy link
Contributor

Wouldn't indexOf(connection) suffice here? I imagine that executes a lot faster. Your thoughts @dresende, @NateLillich ?

Reference: https://github.com/felixge/node-mysql/blob/master/lib/Pool.js#L139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ronkorving