Use indexOf to find connection when removing from pool

fixes #611

Author: dougwilson

Changes.md

@@ -6,6 +6,8 @@ you spot any mistakes.
 
 ## HEAD
 
+* Use indexOf instead of for loops removing conn from pool #611
+
 ## v2.1.1 (2014-03-13)
 
 * fix authentication w/password failure for node.js 0.10.5 #746 #752

lib/Pool.js

@@ -148,20 +148,16 @@ Pool.prototype.query = function (sql, values, cb) {
 };
 
 Pool.prototype._removeConnection = function(connection) {
-  var i;
+  var index;
 
-  for (i = 0; i < this._allConnections.length; i++) {
-    if (this._allConnections[i] === connection) {
-      this._allConnections.splice(i, 1);
-      break;
-    }
+  if ((index = this._allConnections.indexOf(connection)) !== -1) {
+    // Remove connection from all connections
+    this._allConnections.splice(index, 1);
   }
 
-  for (i = 0; i < this._freeConnections.length; i++) {
-    if (this._freeConnections[i] === connection) {
-      this._freeConnections.splice(i, 1);
-      break;
-    }
+  if ((index = this._freeConnections.indexOf(connection)) !== -1) {
+    // Remove connection from free connections
+    this._freeConnections.splice(index, 1);
   }
 
   this.releaseConnection(connection);