Skip to content

Memory leak in PoolCluster.prototype.getConnection #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
atishay opened this issue Sep 11, 2013 · 0 comments · Fixed by #613
Closed

Memory leak in PoolCluster.prototype.getConnection #588

atishay opened this issue Sep 11, 2013 · 0 comments · Fixed by #613

Comments

@atishay
Copy link

atishay commented Sep 11, 2013

In PoolCluster.prototype.getConnection, the variable "namespace" is used without declaration.

Release: alpha9
File: PoolCluster.js
Line no: 69

namespace = this.of();

should be

var namespace = this.of();
rwky added a commit to rwky/node-mysql that referenced this issue Oct 11, 2013
@rwky
Fixed mysqljs#588 missing variable declaration
e5a980c
@rwky rwky mentioned this issue Oct 11, 2013
Merged
felixge added a commit that referenced this issue Oct 12, 2013
@felixge
Merge pull request #613 from rwky/master
e1fc958 
Fixed #588 missing variable declaration
slavisa1014 added a commit to slavisa1014/mysql that referenced this issue Jan 30, 2025
@slavisa1014
Fixed mysqljs/mysql#588 missing variable declaration
84b700f
slavisa1014 added a commit to slavisa1014/mysql that referenced this issue Jan 30, 2025
@slavisa1014
Merge pull request #613 from rwky/master
5996cb8 
Fixed mysqljs/mysql#588 missing variable declaration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed felixge/node-mysql#588 missing variable declaration rwky/node-mysql
1 participant
@atishay