Charsets support

[fuson]

Hi guys.

Will it please you to stop ignoring all non-utf8 world and add iconv support, cause we have to use workarounds like:

const converter = new iconv.Iconv('windows-1251',
                                                   'utf8');

and in query

typeCast: function (field, next) {
    if (field.name === 'name') {
        return converter.convert(field.buffer()).toString();
    }

    return next();
}

And the same crap (in real apps we use wrappers sure) we have to add in every project!

Please, spend 30 minutes and iconv support in mainstream :)

[felixge]

I am sorry to hear our library has disappointed you. I am
herby refunding you the money you have paid.

Seriously: If you send a good patch, we will merge it.

[fuson]

Yes, i'm really disappoint and I understand that all do not care about it. But i hope you know, not all node.js users competent enough to make correct pull requests for a fundamental modules, like yours. Yes, we can make patch for our use cases (and we did it sure), but I realize that these workarounds are not suitable for inclusion in the main development branch.

It was only cry from the heart, sorry for it.

[dresende]

You don't have to be an expert, just need to know how to make a pull request (it's not that hard). After the first commit we can comment and improve the code before merging. That's what open source culture is all about.