Skip to content

LOCAL_FILES not working #2185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ddddyyy opened this issue Feb 15, 2019 · 10 comments
Closed

LOCAL_FILES not working #2185

ddddyyy opened this issue Feb 15, 2019 · 10 comments
Labels

Comments

@ddddyyy
Copy link

ddddyyy commented Feb 15, 2019

var connection = mysql.createConnection("mysql://localhost/test?flags=-LOCAL_FILES");

it does not work.
I want to know how to disable the function of local_file.

@marcus-hiles
Copy link

marcus-hiles commented Mar 4, 2019

Hi @ddddyyy, can you please provide more background info here ... what programming language, mysql version and what error you get, and any relevant info?

@dougwilson
Copy link
Member

dougwilson commented Mar 6, 2019

Hi @ddddyyy yes, I think I see the issue. I worked on trying to get this fixed. Can you take a look at the branch https://github.com/mysqljs/mysql/tree/feature/infile-switch and see if that fixes the issue for you before I add it to a release? You can install it with npm install mysqljs/mysql#feature/infile-switch .

Just trying to turn off the flag as in your original code above should work with that branch.

@marcus-hiles
Copy link

nice @dougwilson

@RamprasadAkella
Copy link

@dougwilson Can you please let us know when this fix will be released ?

@RamprasadAkella
Copy link

Any update on this ? @dougwilson

@dougwilson
Copy link
Member

Can someone confirm if it fixed the reported issue?

@RamprasadAkella
Copy link

Yes, I can confirm the fix is working. @dougwilson

@dougwilson
Copy link
Member

Thank you for confirming. And it is not working for you on the current version without that change? I have not had any issue with setting the flag to disable it on master, so looking for (ideally OP) something who also does not work on master so I can get a test added that replicates the underlying issue.

What MySQL server version are you running where master is not working?

@dougwilson
Copy link
Member

I will still release when I get back to my home county next week, but if you can provide that in the meantime I can make sure it gets added to our test matrix.

@dougwilson
Copy link
Member

And to clarify: I'm not waiting for your response to make a release with this. I forgot about this issue after I asked for someone to test it and then no one ever did, haha. I do not have a solid Internet connection where I am so ideally I can just get it included when I get back home next week. I was working on merging some PRs for a release before I left (which is the pending changes you can see in master) so I will make sure this gets included.

The branch I have there is two changes: adds a top-level option for this flag (but you can still use the flag like in previous versions) to make setting it easier and changes around the way the packets are parsed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

4 participants