Skip to content

Update bignumber.js to v2.0.5 #1037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MikeMcl opened this issue Mar 25, 2015 · 2 comments
Closed

Update bignumber.js to v2.0.5 #1037

MikeMcl opened this issue Mar 25, 2015 · 2 comments

Comments

@MikeMcl
Copy link

MikeMcl commented Mar 25, 2015

Regrettably, a critical (though very rarely manifesting) bug has been found in the division operation in versions v2.0.0 - v2.0.3 of bignumber.js.

Please update to v2.0.5.
@sidorares
Copy link
Member

MikeMcl/bignumber.js#58

it probably does not directly affect this library as we are only constructing bignum and not doing any math (but users might have the issue by using result)

@dougwilson
Copy link
Member

Thanks, @MikeMcl for the note!

And @sidorares all we do is .plus and .times and then we call .toString() and give the user a string; the users do not have any idea that we are even using bignumber.js :)

seangarner pushed a commit to seangarner/node-mysql that referenced this issue May 11, 2015
@dougwilson @seangarner
Update bignumber.js to 2.0.5
07a178f 
closes mysqljs#1037
closes mysqljs#1038
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dougwilson @sidorares @MikeMcl