Skip to content

How to remove group from PoolCluster? #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mlshvdv opened this issue Feb 20, 2015 · 3 comments
Closed

How to remove group from PoolCluster? #1006

mlshvdv opened this issue Feb 20, 2015 · 3 comments

Comments

@mlshvdv
Copy link
Contributor

mlshvdv commented Feb 20, 2015

Hello.

I need to remove some group of PoolCluster by pattern. For example:

poolCluster.add('shard1', config);
poolCluster.add('shard2', config);
poolCluster.add('shard3', config);

Sometime later I need to remove one of group:

poolCluster.remove('shard2');
@dougwilson
Copy link
Member

Currently there is no way to remove nodes from the pool cluster, but PRs are welcome!

@mlshvdv
Copy link
Contributor Author

mlshvdv commented Feb 21, 2015

Ok. Do you think it necessary to make emit('remove', node.id) if the removal is a manual? Or maybe add emit('removeManually', node.id) in this case?

@mlshvdv
Copy link
Contributor Author

mlshvdv commented Feb 21, 2015

Please pay attention on PR #1007 for current issue.

seangarner pushed a commit to seangarner/node-mysql that referenced this issue May 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants