Skip to content

protocol_classic: clarify param type and flag #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions sql/protocol_classic.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1504,9 +1504,12 @@ int Protocol_classic::read_packet() {
<td>new_params_bind_flag</td>
<td>Always 1. Malformed packet error if not 1</td></tr>
<tr><td colspan="3">if new_params_bind_flag, for each parameter {</td></tr>
<tr><td>@ref a_protocol_type_int2 "int&lt;2&gt;"</td>
<td>param_type_and_flag</td>
<td>Parameter type (2 bytes). The MSB is reserved for unsigned flag</td></tr>
<tr><td>@ref a_protocol_type_int1 "int&lt;1&gt;"</td>
<td>parameter_type</td>
<td>Parameter type (1 bytes). See ::enum_field_type</td></tr>
<tr><td>@ref a_protocol_type_int1 "int&lt;1&gt;"</td>
<td>parameter_flags</td>
<td>Parameter flags (1 bytes). Set to 128 if unsigned.</td></tr>
<tr><td>@ref sect_protocol_basic_dt_string_le "string&lt;lenenc&gt;"</td>
<td>parameter name</td>
<td>String</td></tr>
Expand Down Expand Up @@ -2113,9 +2116,12 @@ int Protocol_classic::read_packet() {
<td>new_params_bind_flag</td>
<td>Flag if parameters must be re-bound</td></tr>
<tr><td colspan="3">if new_params_bind_flag, for each parameter {</td></tr>
<tr><td>@ref a_protocol_type_int2 "int&lt;2&gt;"</td>
<tr><td>@ref a_protocol_type_int1 "int&lt;1&gt;"</td>
<td>parameter_type</td>
<td>Type of the parameter value. See ::enum_field_type</td></tr>
<tr><td>@ref a_protocol_type_int1 "int&lt;1&gt;"</td>
<td>parameter_flags</td>
<td>Parameter flags (1 bytes). Set to 128 if unsigned.</td></tr>
<tr><td colspan="3">if ::CLIENT_QUERY_ATTRIBUTES is on {</td></tr>
<tr><td>@ref sect_protocol_basic_dt_string_le "string&lt;lenenc&gt;"</td>
<td>parameter_name</td>
Expand Down